migrate transfer process screen to compose screen #2583 #2585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AvneetSingh2001
requested changes
May 13, 2024
app/src/main/java/org/mifos/mobile/ui/transfer_process/TransferProcessComposeFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mifos/mobile/ui/transfer_process/TransferProcessComposeFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mifos/mobile/ui/transfer_process/TransferProcessComposeFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mifos/mobile/ui/transfer_process/TransferProcessViewModel.kt
Outdated
Show resolved
Hide resolved
|
@Saifuddin53 requested some change, please update the code accordingly. Also can you please add screen recording as well |
Saifuddin53
force-pushed
the
migration_transfer_process_compose
branch
from
6ec885e
to
d53c2a6
Compare
Saifuddin53
force-pushed
the
migration_transfer_process_compose
branch
from
d53c2a6
to
896af28
Compare
|
@Saifuddin53 , can you check why are we getting HTTP 400 response for this? |
|
I think it's a server side error |
|
can you paste the logs about the error here |
|
|
The same error is coming in our view-based screen. It would be solved when we migrate our previous screen which is SavingsMakeTransferFragment as it is passing null for the payto and payfrom fields |
Recording.2024-05-15.094427.mp4 |
@AvneetSingh2001 here the showSavingsAccountTemplate function is not able to fetch the accounts from the AccountOptions list
|
app/src/main/java/org/mifos/mobile/ui/transfer_process/TransferProcessComposeFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mifos/mobile/ui/transfer_process/TransferProcessScreen.kt
Outdated
Show resolved
Hide resolved
Saifuddin53
force-pushed
the
migration_transfer_process_compose
branch
from
896af28
to
998c1d9
Compare
itsPronay
reviewed
May 19, 2024
app/src/main/java/org/mifos/mobile/ui/transfer_process/TransferProcessComposeFragment.kt
Outdated
Show resolved
Hide resolved
itsPronay
reviewed
May 19, 2024
app/src/main/java/org/mifos/mobile/ui/transfer_process/TransferProcessScreen.kt
Show resolved
Hide resolved
|
@AvneetSingh2001 can you please review it again |
|
@Saifuddin53 I see you have multiple commits. Please squash them |
itsPronay
reviewed
Jun 3, 2024
app/src/main/java/org/mifos/mobile/ui/transfer_process/TransferProcessComposeFragment.kt
Outdated
Show resolved
Hide resolved
itsPronay
suggested changes
Jun 3, 2024
|
also please reformat your code, I believe it's ctrl + alt + L |
itsPronay
reviewed
Jun 3, 2024
app/src/main/java/org/mifos/mobile/ui/transfer_process/TransferProcessScreen.kt
Outdated
Show resolved
Hide resolved
# Conflicts: # app/src/main/java/org/mifos/mobile/ui/activities/HomeActivity.kt
akashmeruva9
pushed a commit
to akashmeruva9/mifos-mobile
that referenced
this pull request
Jul 1, 2024
migrate transfer process screen to compose screen openMF#2583 (openMF#2585) refactor: qr code display migration (openMF#2609) Migrate Beneficiary List from XML to compose (openMF#2607) "Added MIfos Logo to RegistrationScreen" (openMF#2613) * Added Image to RegistrationScreen * "Added Image to RegistrationScreen" Bug: Resolved Swipe Refresh Not Working in RecentTransaction Screen Compose (openMF#2617) * "Resolved Swipe Refresh Not Working" * Resolved Swipe Refresh Not Working * Centered the Swipe Refresh And Added Padding migrate saving accounts transaction screen to compose openMF#2588 (openMF#2596) * migrate saving accounts transaction screen to compose openMF#2588 * Update SavingAccountsTransactionTopBar.kt * init * init * refactor: savings accounts screen migration * refactor: savings accounts screen migration --------- Co-authored-by: Avneet Singh <avneetmaankiya@gmail.com> fix#2615 Missing TopAppBar navigation back implementation in AddBeneficiaryScreen (openMF#2616) fix#2610: Scrolling Disabled in TransferProcessFragment (openMF#2611) fix#2610: Scrolling Disabled in TransferProcessFragment fix#2610: Scrolling Disabled in TransferProcessFragment Beneficiary application (openMF#2618) Settings screen migration (openMF#2619) refactor: Registration Module
therajanmaurya
pushed a commit
that referenced
this pull request
Jul 1, 2024
* A migrate transfer process screen to compose screen #2583 (#2585) refactor: qr code display migration (#2609) Migrate Beneficiary List from XML to compose (#2607) "Added MIfos Logo to RegistrationScreen" (#2613) * Added Image to RegistrationScreen * "Added Image to RegistrationScreen" Bug: Resolved Swipe Refresh Not Working in RecentTransaction Screen Compose (#2617) * "Resolved Swipe Refresh Not Working" * Resolved Swipe Refresh Not Working * Centered the Swipe Refresh And Added Padding migrate saving accounts transaction screen to compose #2588 (#2596) * migrate saving accounts transaction screen to compose #2588 * Update SavingAccountsTransactionTopBar.kt * init * init * refactor: savings accounts screen migration * refactor: savings accounts screen migration --------- Co-authored-by: Avneet Singh <avneetmaankiya@gmail.com> fix#2615 Missing TopAppBar navigation back implementation in AddBeneficiaryScreen (#2616) fix#2610: Scrolling Disabled in TransferProcessFragment (#2611) fix#2610: Scrolling Disabled in TransferProcessFragment fix#2610: Scrolling Disabled in TransferProcessFragment Beneficiary application (#2618) Settings screen migration (#2619) refactor: Registration Module * refactor: registration module --------- Co-authored-by: Saifuddin Adenwala <adenwala32@gmail.com>
This was referenced Jul 1, 2024
akashmeruva9
pushed a commit
to akashmeruva9/mifos-mobile
that referenced
this pull request
Jul 3, 2024
migrate transfer process screen to compose screen openMF#2583 (openMF#2585) refactor: qr code display migration (openMF#2609) Migrate Beneficiary List from XML to compose (openMF#2607) "Added MIfos Logo to RegistrationScreen" (openMF#2613) * Added Image to RegistrationScreen * "Added Image to RegistrationScreen" Bug: Resolved Swipe Refresh Not Working in RecentTransaction Screen Compose (openMF#2617) * "Resolved Swipe Refresh Not Working" * Resolved Swipe Refresh Not Working * Centered the Swipe Refresh And Added Padding migrate saving accounts transaction screen to compose openMF#2588 (openMF#2596) * migrate saving accounts transaction screen to compose openMF#2588 * Update SavingAccountsTransactionTopBar.kt * init * init * refactor: savings accounts screen migration * refactor: savings accounts screen migration --------- Co-authored-by: Avneet Singh <avneetmaankiya@gmail.com> fix#2615 Missing TopAppBar navigation back implementation in AddBeneficiaryScreen (openMF#2616) fix#2610: Scrolling Disabled in TransferProcessFragment (openMF#2611) fix#2610: Scrolling Disabled in TransferProcessFragment fix#2610: Scrolling Disabled in TransferProcessFragment Beneficiary application (openMF#2618) Settings screen migration (openMF#2619) refactor: Registration Module
akashmeruva9
pushed a commit
to akashmeruva9/mifos-mobile
that referenced
this pull request
Jul 5, 2024
migrate transfer process screen to compose screen openMF#2583 (openMF#2585) refactor: qr code display migration (openMF#2609) Migrate Beneficiary List from XML to compose (openMF#2607) "Added MIfos Logo to RegistrationScreen" (openMF#2613) * Added Image to RegistrationScreen * "Added Image to RegistrationScreen" Bug: Resolved Swipe Refresh Not Working in RecentTransaction Screen Compose (openMF#2617) * "Resolved Swipe Refresh Not Working" * Resolved Swipe Refresh Not Working * Centered the Swipe Refresh And Added Padding migrate saving accounts transaction screen to compose openMF#2588 (openMF#2596) * migrate saving accounts transaction screen to compose openMF#2588 * Update SavingAccountsTransactionTopBar.kt * init * init * refactor: savings accounts screen migration * refactor: savings accounts screen migration --------- Co-authored-by: Avneet Singh <avneetmaankiya@gmail.com> fix#2615 Missing TopAppBar navigation back implementation in AddBeneficiaryScreen (openMF#2616) fix#2610: Scrolling Disabled in TransferProcessFragment (openMF#2611) fix#2610: Scrolling Disabled in TransferProcessFragment fix#2610: Scrolling Disabled in TransferProcessFragment Beneficiary application (openMF#2618) Settings screen migration (openMF#2619) refactor: Registration Module
akashmeruva9
pushed a commit
to akashmeruva9/mifos-mobile
that referenced
this pull request
Jul 5, 2024
# This is the 1st commit message: refactor: openMF#2636 Use MaterialTheme colors for a uniform theme (openMF#2637) # This is the commit message openMF#2: refactor: savings module (openMF#2635) # This is the commit message openMF#3: refactor: qr module (openMF#2638) # This is the commit message openMF#4: A migrate transfer process screen to compose screen openMF#2583 (openMF#2585) refactor: qr code display migration (openMF#2609) Migrate Beneficiary List from XML to compose (openMF#2607) "Added MIfos Logo to RegistrationScreen" (openMF#2613) * Added Image to RegistrationScreen * "Added Image to RegistrationScreen" Bug: Resolved Swipe Refresh Not Working in RecentTransaction Screen Compose (openMF#2617) * "Resolved Swipe Refresh Not Working" * Resolved Swipe Refresh Not Working * Centered the Swipe Refresh And Added Padding migrate saving accounts transaction screen to compose openMF#2588 (openMF#2596) * migrate saving accounts transaction screen to compose openMF#2588 * Update SavingAccountsTransactionTopBar.kt * init * init * refactor: savings accounts screen migration * refactor: savings accounts screen migration --------- Co-authored-by: Avneet Singh <avneetmaankiya@gmail.com> fix#2615 Missing TopAppBar navigation back implementation in AddBeneficiaryScreen (openMF#2616) fix#2610: Scrolling Disabled in TransferProcessFragment (openMF#2611) fix#2610: Scrolling Disabled in TransferProcessFragment fix#2610: Scrolling Disabled in TransferProcessFragment Beneficiary application (openMF#2618) Settings screen migration (openMF#2619) refactor: Registration Module # This is the commit message openMF#5: refactor: Login module # This is the commit message openMF#6: refactor: Login module # This is the commit message openMF#7: refactor: Recent Login module # This is the commit message openMF#8: A migrate transfer process screen to compose screen openMF#2583 (openMF#2585) refactor: qr code display migration (openMF#2609) Migrate Beneficiary List from XML to compose (openMF#2607) "Added MIfos Logo to RegistrationScreen" (openMF#2613) * Added Image to RegistrationScreen * "Added Image to RegistrationScreen" Bug: Resolved Swipe Refresh Not Working in RecentTransaction Screen Compose (openMF#2617) * "Resolved Swipe Refresh Not Working" * Resolved Swipe Refresh Not Working * Centered the Swipe Refresh And Added Padding migrate saving accounts transaction screen to compose openMF#2588 (openMF#2596) * migrate saving accounts transaction screen to compose openMF#2588 * Update SavingAccountsTransactionTopBar.kt * init * init * refactor: savings accounts screen migration * refactor: savings accounts screen migration --------- Co-authored-by: Avneet Singh <avneetmaankiya@gmail.com> fix#2615 Missing TopAppBar navigation back implementation in AddBeneficiaryScreen (openMF#2616) fix#2610: Scrolling Disabled in TransferProcessFragment (openMF#2611) fix#2610: Scrolling Disabled in TransferProcessFragment fix#2610: Scrolling Disabled in TransferProcessFragment Beneficiary application (openMF#2618) Settings screen migration (openMF#2619) refactor: Registration Module # This is the commit message openMF#9: refactor: Login module refactor: Login module refactor: Recent Login module refactor: transfer process module (openMF#2644)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2583
Please Add Screenshots If there are any UI changes.
Before :
After :
Videos:
mifos.video.mp4